Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in apmgrpc/client.go #1574

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

shubhamsharma7867
Copy link
Contributor

@shubhamsharma7867 shubhamsharma7867 commented Feb 8, 2024

"fixed typo from
grpc.UnaryClientInterceptor to grpc.StreamClientInterceptor in the comments for NewStreamClientInterceptor apmgrpc/client.go"

…ceptor in the comments for NewStreamClientInterceptor in apmgrpc/client.go
@shubhamsharma7867 shubhamsharma7867 requested a review from a team as a code owner February 8, 2024 19:32
Copy link

cla-checker-service bot commented Feb 8, 2024

💚 CLA has been signed

@shubhamsharma7867
Copy link
Contributor Author

shubhamsharma7867 commented Mar 8, 2024

Hey @dmathieu @kruskall @carsonip when can I expect this pull request to merge with master?

@dmathieu
Copy link
Member

We currently have an issue with the coverage check, which is preventing any merge. We need to fix that first.

@dmathieu
Copy link
Member

run docs-build

1 similar comment
@dmathieu
Copy link
Member

run docs-build

@dmathieu dmathieu merged commit 2966ccc into elastic:main Mar 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants