Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of the SpanIDFieldName constant in apmzerolog #1578

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

dassump
Copy link
Contributor

@dassump dassump commented Mar 8, 2024

To improve code maintainability and follow the same pattern in traceContextHook.Run of using other constants.

@dassump dassump requested a review from a team as a code owner March 8, 2024 10:28
Copy link

cla-checker-service bot commented Mar 8, 2024

💚 CLA has been signed

@dmathieu
Copy link
Member

Could you sign the CLA so we can review your PR?

@dassump
Copy link
Contributor Author

dassump commented Mar 12, 2024

Hi @dmathieu, I signed up for the CLA. Thanks

@kruskall kruskall enabled auto-merge (squash) March 12, 2024 14:13
@dmathieu
Copy link
Member

run docs-build

@kruskall kruskall merged commit cbb31d6 into elastic:main Mar 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants