Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-spec updatecli workflow #3153

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 8, 2023

What does this pull request do?

Moves the update specs workflow from apm-server to the consumer using updatecli to have a "dependabot"-like experience.

How to test

GITHUB_TOKEN=<token>\
GIT_USER=<username> \
GIT_EMAIL=j<email> \
updatecli diff -c .ci/update-specs.yml

Related issues

@reakaleek reakaleek requested review from a team February 8, 2023 13:42
@reakaleek reakaleek self-assigned this Feb 8, 2023
@github-actions github-actions bot added agent-nodejs Make available for APM Agents project planning. community triage labels Feb 8, 2023
@reakaleek reakaleek marked this pull request as ready for review February 8, 2023 13:42
@apmmachine
Copy link
Contributor

apmmachine commented Feb 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-02-09T08:24:28.967+0000

  • Duration: 22 min 50 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should this PR also handle removing the now obsolete (I think) https://github.com/elastic/apm-agent-nodejs/blob/main/test/integration/api-schema/apm-server-schema/log.json file? It was removed from apm-server.git (where these spec files used to be sync'd from) in Add ECS log files to the intake log endpoint apm-server#9349

  2. I guess updatecli doesn't support mapping a full directory or a glob pattern?

@reakaleek
Copy link
Member Author

reakaleek commented Feb 9, 2023

  1. Should this PR also handle removing the now obsolete (I think) https://github.com/elastic/apm-agent-nodejs/blob/main/test/integration/api-schema/apm-server-schema/log.json file? It was removed from apm-server.git (where these spec files used to be sync'd from) in elastic/apm-server#9349
  2. I guess updatecli doesn't support mapping a full directory or a glob pattern?
  1. Since, the log.json file is also not part of https://github.com/elastic/apm-data/tree/main/input/elasticapm/docs/spec/v2, I guess it's safe to remove it. Will do that in this PR.

  2. Yes, unfortunately there is no native way to sync/manipulate multiple files at once. We concluded, that having hardcoded list is feasible in this case because the amount of files rarely changes.

Update:

3f85aa3

@reakaleek
Copy link
Member Author

@trentm

FYI, there is an issue to bundle the schemas into one file.

elastic/apm-data#15

Hence, the mentioned issues will be solved there.

@reakaleek reakaleek merged commit ab6ecc2 into elastic:main Feb 13, 2023
@reakaleek reakaleek deleted the feature/update-specs-action branch February 13, 2023 08:13
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
* Add update-spec updatecli workflow

* Add to OpenTelemetry workflow

* Remove deprecated log.json file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants