-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update-spec updatecli workflow #3153
Add update-spec updatecli workflow #3153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Should this PR also handle removing the now obsolete (I think) https://github.com/elastic/apm-agent-nodejs/blob/main/test/integration/api-schema/apm-server-schema/log.json file? It was removed from apm-server.git (where these spec files used to be sync'd from) in Add ECS log files to the intake log endpoint apm-server#9349
-
I guess
updatecli
doesn't support mapping a full directory or a glob pattern?
Update: |
FYI, there is an issue to bundle the schemas into one file. Hence, the mentioned issues will be solved there. |
* Add update-spec updatecli workflow * Add to OpenTelemetry workflow * Remove deprecated log.json file
What does this pull request do?
Moves the update specs workflow from apm-server to the consumer using updatecli to have a "dependabot"-like experience.
How to test
Related issues