Refactor consumer transaction outcome

elastic · May 15, 2024 · f9f7e86 · f9f7e86
1 parent 3d74b19
commit f9f7e86
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/lib/elastic_apm/spies/racecar.rb b/lib/elastic_apm/spies/racecar.rb
@@ -34,23 +34,15 @@ def start_process_message(event)
             start_process_transaction(event: event, kind: 'process_message')
           end
           def process_message(event)
-            transaction = ElasticAPM.current_transaction
-            error_present = !event.payload[:unrecoverable_delivery_error].nil?
-            transaction.outcome = error_present ? Transaction::Outcome::FAILURE : Transaction::Outcome::SUCCESS
-            transaction.done(error_present ? :error : :success)
-
+            record_outcome(event: event)
             ElasticAPM.end_transaction
           end
 
           def start_process_batch(event)
             start_process_transaction(event: event, kind: 'process_batch')
           end
           def process_batch(event)
-            transaction = ElasticAPM.current_transaction
-            error_present = !event.payload[:unrecoverable_delivery_error].nil?
-            transaction.outcome = error_present ? Transaction::Outcome::FAILURE : Transaction::Outcome::SUCCESS
-            transaction.done(error_present ? :error : :success)
-
+            record_outcome(event: event)
             ElasticAPM.end_transaction
           end
 
@@ -60,6 +52,13 @@ def start_process_transaction(event:, kind:)
             ElasticAPM.start_transaction("#{event.payload[:consumer_class]}##{kind}", TYPE)
             ElasticAPM.current_transaction.context.set_service(framework_name: 'racecar', framework_version: Racecar::VERSION)
           end
+
+          def record_outcome(event:)
+            transaction = ElasticAPM.current_transaction
+            error_present = !event.payload[:unrecoverable_delivery_error].nil?
+            transaction.outcome = error_present ? Transaction::Outcome::FAILURE : Transaction::Outcome::SUCCESS
+            transaction.done(error_present ? :error : :success)
+          end
         end
 
         class ProducerSubscriber < ActiveSupport::Subscriber