tracing: Start Stream span at the top

Move the `StartSpan` call at the top of the `processor.HandleStream` function so the semaphore acquisition is also tracked, not only the stream handling. Signed-off-by: Marc Lopez Rubio <[email protected]>
elastic · Aug 1, 2023 · 69337be · 69337be
1 parent 31428f0
commit 69337be
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/input/elasticapm/processor.go b/input/elasticapm/processor.go
@@ -245,6 +245,8 @@ func (p *Processor) HandleStream(
 	processor modelpb.BatchProcessor,
 	result *Result,
 ) error {
+	sp, ctx := apm.StartSpan(ctx, "Stream", "Reporter")
+	defer sp.End()
 	// Limit the number of concurrent batch decodes.
 	//
 	// The semaphore defaults to 200 (N), only allowing N requests to read
@@ -282,9 +284,6 @@ func (p *Processor) HandleStream(
 		}
 	}
 
-	sp, ctx := apm.StartSpan(ctx, "Stream", "Reporter")
-	defer sp.End()
-
 	if async {
 		// The semaphore is released by handleStream
 		shouldReleaseSemaphore = false