feat: strict http headers null validation with tests (#140)

elastic · Aug 11, 2023 · f5da0e6 · f5da0e6
1 parent a636758
commit f5da0e6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/input/elasticapm/internal/modeldecoder/nullable/nullable.go b/input/elasticapm/internal/modeldecoder/nullable/nullable.go
@@ -128,7 +128,6 @@ func init() {
 			h := http.Header{}
 			for key, val := range m {
 				switch v := val.(type) {
-				case nil:
 				case string:
 					h.Add(key, v)
 				case []interface{}:

diff --git a/input/elasticapm/internal/modeldecoder/nullable/nullable_test.go b/input/elasticapm/internal/modeldecoder/nullable/nullable_test.go
@@ -326,6 +326,8 @@ func TestHTTPHeader(t *testing.T) {
 			}},
 		{name: "valid2", input: `{"h":{"k":["a","b"]}}`, isSet: true, val: http.Header{"K": []string{"a", "b"}}},
 		{name: "null", input: `{"h":null}`},
+		{name: "null-value", input: `{"h":{"k": null}`, fail: true},
+		{name: "null-array", input: `{"h":{"k": [null]}`, fail: true},
 		{name: "invalid-type", input: `{"h":""}`, fail: true, isSet: true},
 		{name: "invalid-array", input: `{"h":{"k":["a",23]}}`, isSet: true, fail: true},
 		{name: "missing", input: `{}`},