Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map newer HTTP Server Semantic Conventions to URL #254

Closed
stevejgordon opened this issue Apr 5, 2024 · 3 comments · Fixed by #263
Closed

Map newer HTTP Server Semantic Conventions to URL #254

stevejgordon opened this issue Apr 5, 2024 · 3 comments · Fixed by #263
Assignees

Comments

@stevejgordon
Copy link
Contributor

Since v1.21.0 of the trace Semantic Conventions, new attributes are used:

  • net.host.name -> server.address
  • net.host.port -> server.port
  • http.target -> url.path and url.query
  • http.scheme -> url.scheme

We currently don't map all of these for the OTLP intake, resulting in a poor UI experience. It seems that only the scheme is coming through.

For example, the trace sample UI isn't able to display the URL of the request which started the transaction.

image

Should be closer to:

image

@simitt
Copy link
Contributor

simitt commented Apr 11, 2024

@stevejgordon would you have capacities to take this one on?

@stevejgordon
Copy link
Contributor Author

@simitt Yes, I'd like to give it a go. Sorry, I thought I'd self-assigned when I opened it! I'm hoping to make some time next week to look at this.

@stevejgordon stevejgordon self-assigned this Apr 12, 2024
@simitt
Copy link
Contributor

simitt commented Apr 12, 2024

No rush from my side; thanks for taking it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants