-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new attribute mappings #139
Conversation
ff0bfc7
to
b70c62a
Compare
4b363ac
to
bba4230
Compare
bba4230
to
0babeca
Compare
Thanks for the approval, @kruskall. I rebased this so that the commit was signed. What's the process for getting this merged? |
There's no specific process, once the PR is merged the dependency in apm-server will be bumped and the changes included in the next release. |
removing approval to avoid merging this by mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevejgordon I think the changes for TranslateSpan are fine, but there's a couple of issues in TranslateTransaction. Can you please check those? The server.*
fields are mentioned in the 1.21 schema here: https://github.com/open-telemetry/semantic-conventions/blob/4bbb8c907402caa90bc077214e8a2c78807c1ab9/schemas/1.21.0#L15-L19
Adding attributes for a newer semver version is fine as long as we keep support for the older version. Longer term we need to figure out something sustainable, but we don't need to solve that today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevejgordon thanks, LGTM - just one minor comment.
Adds support for new attributes defined in more recent semantic conversion schema versions. This initial set is needed to support attributes emitted by the .NET Elasticsearch client instrumentation, which conforms to
https://opentelemetry.io/schemas/1.21.0
. Thego.opentelemetry.io/collector/semconv/v1.5.0
package does not include these attributes, and the latest version only includes up to1.18.0
. For now, I've included the new attributes directly in our mapping code and updated them to ensure both old and new attribute names are supported. In the long term, we need to discuss how we handle other new attributes and have a strategy for mapping new schema versions as they are made stable and released.