Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use vtpool wherever possible #152

Closed
wants to merge 1 commit into from

Conversation

kruskall
Copy link
Member

Closes #130

@kruskall
Copy link
Member Author

I've run the benchmark and compared with main:

                            │   old.txt   │               new.txt               │
                            │   sec/op    │   sec/op     vs base                │
MapToModelPb/error-model-20   5.093µ ± 2%   2.089µ ± 2%  -58.99% (p=0.000 n=10)

                            │   old.txt   │              new.txt               │
                            │    B/op     │    B/op     vs base                │
MapToModelPb/error-model-20   5681.5 ± 0%   929.0 ± 0%  -83.65% (p=0.000 n=10)

                            │  old.txt   │              new.txt               │
                            │ allocs/op  │ allocs/op   vs base                │
MapToModelPb/error-model-20   75.00 ± 0%   26.00 ± 0%  -65.33% (p=0.000 n=10)

@kruskall
Copy link
Member Author

I've run the benchmark and compared with main:

NOTE: both benchmarks are reusing an event by calling ResetVT so in theory the actual performance of main is slower than what's reported above.

@kruskall
Copy link
Member Author

This should be completely merged in now 🎉

@kruskall kruskall closed this Sep 27, 2023
@kruskall kruskall deleted the feat/use-vtpool branch September 27, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use modelpb.<Type>FromVTPool wherever possible
1 participant