Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-action: support pull_request_target and pull_request events #213

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 5, 2024

github.event_name != 'pull_request' will be always true since it listens for pull_request_target events.

Let's use the startswith condition for pull_request.

@v1v v1v requested a review from a team February 5, 2024 09:39
@v1v v1v requested a review from a team as a code owner February 5, 2024 09:39
@elastic-apm-tech elastic-apm-tech added the safe-to-test Changes are safe to run in the CI label Feb 5, 2024
kruskall
kruskall previously approved these changes Feb 5, 2024
reakaleek
reakaleek previously approved these changes Feb 5, 2024
.github/workflows/bench-diff.yml Outdated Show resolved Hide resolved
@v1v v1v dismissed stale reviews from reakaleek and kruskall via e4e2280 February 5, 2024 10:29
@v1v v1v requested a review from kruskall February 5, 2024 10:29
@v1v v1v enabled auto-merge (squash) February 5, 2024 10:29
@v1v v1v merged commit 575dc0d into elastic:main Feb 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Changes are safe to run in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants