Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating code for pooling #359

Merged
merged 1 commit into from
Sep 3, 2024

Stop generating code for pooling

aee3755
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Stop generating code for pooling #359

Stop generating code for pooling
aee3755
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded Sep 3, 2024 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: aee3755

Base sha: ff9005d

Degraded: false

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 25126.2 0% 25370.8 1% +0.97% (p=0.029 n=4+4)
Encode/format=json-2 13137 0% 13068 0% ~ (p=0.057 n=4+4)
Encode/format=vtproto 4717 1% 4807.8 0% +1.92% (p=0.008 n=5+5)
Encode/format=vtproto-2 2631.2 8% 2593.4 0% ~ (p=0.690 n=5+5)
Decode/format=json 130257 9% 122818 3% ~ (p=0.310 n=5+5)
Decode/format=json-2 67084.6 13% 64450.4 1% ~ (p=0.548 n=5+5)
Decode/format=vtproto 19253 0% 17815.8 1% -7.46% (p=0.008 n=5+5)
Decode/format=vtproto-2 12520 15% 10841.4 13% ~ (p=0.056 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7592 0% 7592 0% ~ (all equal)
Encode/format=json-2 7593 0% 7593 0% ~ (all equal)
Encode/format=vtproto 3072 0% 3072 0% ~ (all equal)
Encode/format=vtproto-2 3072 0% 3072 0% ~ (all equal)
Decode/format=json 14282.2 0% 14283 0% ~ (p=0.429 n=5+5)
Decode/format=json-2 14282 0% 14281.4 0% ~ (p=0.492 n=5+5)
Decode/format=vtproto 12992 0% 12952 0% -0.31% (p=0.008 n=5+5)
Decode/format=vtproto-2 13032 0% 12952 0% ~ (p=0.079 n=4+5)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 26 0% 26 0% ~ (all equal)
Encode/format=json-2 26 0% 26 0% ~ (all equal)
Encode/format=vtproto 1 0% 1 0% ~ (all equal)
Encode/format=vtproto-2 1 0% 1 0% ~ (all equal)
Decode/format=json 379 0% 379 0% ~ (all equal)
Decode/format=json-2 379 0% 379 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 284.7 1% 278.34 5% -2.23% (p=0.016 n=4+5)
NDStreamDecoder-2 147 1% 149.08 5% ~ (p=0.278 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 14963.2 9% 15049.4 10% ~ (p=0.841 n=5+5)
APMEventToJSON/to-json-2 12443.4 1% 12459.6 1% ~ (p=1.000 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2616 0% 2616 0% ~ (all equal)
APMEventToJSON/to-json-2 2616 0% 2616 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 38 0% 38 0% ~ (all equal)
APMEventToJSON/to-json-2 38 0% 38 0% ~ (all equal)
View more details on GitHub Actions