Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flaky Semaphore Test #391

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

chore: remove unused batch in unit tests

c6ac341
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Fix Flaky Semaphore Test #391

chore: remove unused batch in unit tests
c6ac341
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result completed Nov 4, 2024 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: c6ac341

Base sha: 46f8e38

Degraded: true

Details

pkg: github.com/elastic/apm-data/codec
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Encode/format=json 25806.6 1% 26651.6 1% +3.27% (p=0.008 n=5+5)
Encode/format=json-2 13525.4 3% 13606.2 1% ~ (p=0.222 n=5+5)
Encode/format=vtproto 4740 1% 4804.6 5% ~ (p=0.452 n=5+5)
Encode/format=vtproto-2 2890.4 12% 2903.2 43% ~ (p=0.286 n=5+5)
Decode/format=json 127928 0% 148117 13% +15.78% (p=0.016 n=4+5)
Decode/format=json-2 66278.4 1% 81840 25% +23.48% (p=0.008 n=5+5)
Decode/format=vtproto 17644.2 1% 18612.6 3% +5.49% (p=0.008 n=5+5)
Decode/format=vtproto-2 10676.6 16% 11086 4% ~ (p=0.151 n=5+5)
name old bytes/op (bytes/op) ± new bytes/op (bytes/op) ± delta ±
Encode/format=json 6564 0% 6564 0% ~ (all equal)
Encode/format=json-2 6564 0% 6564 0% ~ (all equal)
Encode/format=vtproto 2775 0% 2775 0% ~ (all equal)
Encode/format=vtproto-2 2775 0% 2775 0% ~ (all equal)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Encode/format=json 7592 0% 7592 0% ~ (all equal)
Encode/format=json-2 7593 0% 7593 0% ~ (all equal)
Encode/format=vtproto 3072 0% 3072 0% ~ (all equal)
Encode/format=vtproto-2 3072 0% 3072 0% ~ (all equal)
Decode/format=json 14282.2 0% 14282.8 0% ~ (p=0.484 n=5+5)
Decode/format=json-2 14282 0% 14282.4 0% ~ (p=0.802 n=5+5)
Decode/format=vtproto 12952 0% 12952 0% ~ (all equal)
Decode/format=vtproto-2 12952 0% 12952 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Encode/format=json 26 0% 26 0% ~ (all equal)
Encode/format=json-2 26 0% 26 0% ~ (all equal)
Encode/format=vtproto 1 0% 1 0% ~ (all equal)
Encode/format=vtproto-2 1 0% 1 0% ~ (all equal)
Decode/format=json 379 0% 379 0% ~ (all equal)
Decode/format=json-2 379 0% 379 0% ~ (all equal)
Decode/format=vtproto 348 0% 348 0% ~ (all equal)
Decode/format=vtproto-2 348 0% 348 0% ~ (all equal)

pkg: github.com/elastic/apm-data/input/elasticapm/internal/decoder
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
NDStreamDecoder 275.36 4% 281.05 0% ~ (p=0.127 n=5+4)
NDStreamDecoder-2 149.56 4% 146.4 2% ~ (p=0.310 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
NDStreamDecoder 72 0% 72 0% ~ (all equal)
NDStreamDecoder-2 72 0% 72 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
NDStreamDecoder 4 0% 4 0% ~ (all equal)
NDStreamDecoder-2 4 0% 4 0% ~ (all equal)

pkg: github.com/elastic/apm-data/model/modeljson
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
APMEventToJSON/to-json 15194.2 10% 15672.8 9% ~ (p=0.151 n=5+5)
APMEventToJSON/to-json-2 12363.8 2% 12874.4 3% +4.13% (p=0.008 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
APMEventToJSON/to-json 2616 0% 2616 0% ~ (all equal)
APMEventToJSON/to-json-2 2616 0% 2616 0% ~ (all equal)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
APMEventToJSON/to-json 38 0% 38 0% ~ (all equal)
APMEventToJSON/to-json-2 38 0% 38 0% ~ (all equal)
View more details on GitHub Actions