Run test and lint during CI #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
approved these changes
Aug 28, 2023
Makefile
Outdated
| go list -m -json $(MODULE_DEPS) | go run -modfile=tools/go.mod go.elastic.co/go-licence-detector \ | ||
| # See https://github.com/elastic/go-licence-detector/issues/22 | ||
| # TODO: Enable after the licence-detector issue is fixed | ||
| # go list -m -json $(MODULE_DEPS) | go run -modfile=tools/go.mod go.elastic.co/go-licence-detector \ | ||
| -includeIndirect -rules tools/notice/rules.json -validate |
There was a problem hiding this comment.
Suggested change
| -includeIndirect -rules tools/notice/rules.json -validate | |
| # -includeIndirect -rules tools/notice/rules.json -validate |
There was a problem hiding this comment.
I updated the go-license-detector to remove -validate and add a NOTICE.txt (the template was available but not used so far it seems).
axw
approved these changes
Aug 28, 2023
|
Thanks, removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lint and runs both lint and test in CI on new pushes and pull requests.