Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run OTEL collector and optionally continue running after benchmarks #29

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

lahsivjar
Copy link
Contributor

PR implements the following improvements to the OTEL collector (with commit IDs for ease in review):

  • Removes the unused -detailed flag (95a338f): -detailed flag was used in apm-server's bench test to print the detailed metric. In apm-perf/apmbench we print this by default.
  • Always run the OTEL collector (5cf0a7d): before this PR, OTEL collector was run only when collector config were provided. These config specify which metric to store and without the config there was no point in running the collector. With this PR, we run the collector always in preparation for allowing another pipeline to ship all data to a persistent layer instead of only keeping the data in-memory.
  • Allow apmbench to continue running otel collector (50c8a83): Introduces a flag -server-mode to indicate that collector can be kept running even after benchmark has finished. This also plays into adding a persistent pipeline in future.

@lahsivjar lahsivjar requested a review from a team August 29, 2023 04:38
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the persistent pipeline bit, but it looks harmless and simple enough, so happy to merge and see where it goes :)

@lahsivjar lahsivjar merged commit bf84579 into elastic:main Aug 29, 2023
2 checks passed
@lahsivjar lahsivjar deleted the otel-imp branch August 29, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants