Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL collector improvements #36

Merged
merged 2 commits into from
Sep 5, 2023
Merged

OTEL collector improvements #36

merged 2 commits into from
Sep 5, 2023

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Sep 4, 2023 •
edited
Loading

  • Sleeps at the end of benchmark to give some time for the MIS pipelines to finish consuming any remaining entries in the queue.
  • Calculates rate only for non-zero values. This would mean that the reported rate values would not include any leading or trailing series of zeroes.

I am unsure if they are the best improvements, let me know if they seem like a bad idea.

@lahsivjar lahsivjar requested a review from a team as a code owner September 4, 2023 04:56
kruskall
kruskall approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like for this to be more stable/deterministic but LGTM for now!

cmd/apmbench/run.go Show resolved Hide resolved
@lahsivjar lahsivjar merged commit 4ce0d0c into elastic:main Sep 5, 2023
2 checks passed
@lahsivjar lahsivjar deleted the bench-imp branch September 5, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahsivjar @kruskall