Support cross-building #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specify --platform in the golang build stage - Set GOOS and GOARCH env vars - Set CGO_ENABLED=0 to build static binaries - Remove apt-get upgrades; changed base image to chainguard/static I don't think we need buildx?
axw
force-pushed
the
docker-buildplatform
branch
from
330d98b
to
0ef952f
Compare
inge4pres
reviewed
Apr 3, 2024
Comment on lines
-40
to
-58
| # Add minimal stuff | ||
| RUN \ | ||
| apt-get update > /dev/null \ | ||
| && apt-get upgrade -y \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| "apt-utils=*" \ | ||
| "ca-certificates=*" \ | ||
| "curl=*" \ | ||
| "gnupg=*" \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Removing this will break any setup that relies on curl to generate the API key when apmsoak/apmbench are started via bash scripts.
There was a problem hiding this comment.
ugh :)
Thanks for catching that, didn't realise/forgot we were doing this.
inge4pres
requested changes
Apr 3, 2024
|
@inge4pres thanks for catching that, should be resolved with https://github.com/elastic/apm-managed-service/pull/760. PTAL. |
inge4pres
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need buildx?