Skip to content

Commit

Permalink
Always rewrite timestamps and IDs in run-benchmark (#15380) (#15382)
Browse files Browse the repository at this point in the history
As the old apm-perf dependency in apm-server systemtest defaults to
disable rewriting while the latest apm-perf defaults to true, do not
rely on the defaults and always specify -rewrite-timestamps and
-rewrite-ids in make run-benchmark.

(cherry picked from commit e72affe)

Co-authored-by: Carson Ip <[email protected]>
  • Loading branch information
mergify[bot] and carsonip authored Jan 26, 2025
1 parent 1bef974 commit 12309db
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions testing/benchmark/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ log-benckmark-profile:
.PHONY: run-benchmark
run-benchmark: log-benckmark-profile
@ssh $(SSH_OPTS) -i $(SSH_KEY) $(SSH_USER)@$(WORKER_IP) ". .envrc && bin/apmbench -run='$(BENCHMARK_RUN)' \
-rewrite-timestamps -rewrite-ids \
-benchtime=$(BENCHMARK_TIME) -count=$(BENCHMARK_COUNT) -warmup-time=$(BENCHMARK_WARMUP_TIME) \
-agents=$(BENCHMARK_AGENTS) -detailed=$(BENCHMARK_DETAILED) -event-rate=$(BENCHMARK_EVENT_RATE) -cpuprofile=$(BENCHMARK_CPU_OUT)" 2>&1 | tee $(BENCHMARK_RESULT)

Expand Down

0 comments on commit 12309db

Please sign in to comment.