-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otel code.stacktrace field #12096
Conversation
This pull request does not have a backport label. Could you fix it @SylvainJuge? 🙏
NOTE: |
This pull request is now in conflicts. Could you fix it @SylvainJuge? 🙏
|
This pull request is now in conflicts. Could you fix it @SylvainJuge? 🙏
|
This pull request is now in conflicts. Could you fix it @SylvainJuge? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I verified this in ESS 8.13 latest BC. I modified @SylvainJuge is it expected that the code is only set in |
Yes, only spans should have code.stacktrace. |
Motivation/summary
Adds the
span.code.stacktrace
field to store thecode.stacktrace
field added in otel semantic conventions: open-telemetry/semantic-conventions#435Checklist
code.stacktrace
or keep in within thespan
namespace withspan.code.stacktrace
. >> usingcode.stacktrace
to avoid having to deprecate in the future.apmpackage
have been made)For functional changes, consider:
How to test these changes
Related issues
Depends on elastic/apm-data#184 to be merged first, then updating this PR will be required to update the version of apm-data.
Depends on #12386 to be merged too.