Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otel code.stacktrace field #12096

Merged
merged 8 commits into from
Jan 15, 2024
Merged

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Nov 22, 2023

Motivation/summary

Adds the span.code.stacktrace field to store the code.stacktrace field added in otel semantic conventions: open-telemetry/semantic-conventions#435

Checklist

  • decide on having a top-level field code.stacktrace or keep in within the span namespace with span.code.stacktrace. >> using code.stacktrace to avoid having to deprecate in the future.
  • Update CHANGELOG.asciidoc
  • Update package changelog.yml (only if changes to apmpackage have been made)
  • Documentation has been updated

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Depends on elastic/apm-data#184 to be merged first, then updating this PR will be required to update the version of apm-data.

Depends on #12386 to be merged too.

@SylvainJuge SylvainJuge changed the title Add otel span code.stacktrace field Add otel span.code.stacktrace field Nov 22, 2023
Copy link
Contributor

mergify bot commented Nov 22, 2023

This pull request does not have a backport label. Could you fix it @SylvainJuge? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 22, 2023
@SylvainJuge SylvainJuge marked this pull request as ready for review November 23, 2023 10:00
@SylvainJuge SylvainJuge requested a review from a team as a code owner November 23, 2023 10:00
@SylvainJuge SylvainJuge changed the title Add otel span.code.stacktrace field Add otel code.stacktrace field Nov 27, 2023
Copy link
Contributor

mergify bot commented Nov 28, 2023

This pull request is now in conflicts. Could you fix it @SylvainJuge? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b code-stacktrace upstream/code-stacktrace
git merge upstream/main
git push upstream code-stacktrace

Copy link
Contributor

mergify bot commented Dec 5, 2023

This pull request is now in conflicts. Could you fix it @SylvainJuge? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b code-stacktrace upstream/code-stacktrace
git merge upstream/main
git push upstream code-stacktrace

Copy link
Contributor

mergify bot commented Dec 13, 2023

This pull request is now in conflicts. Could you fix it @SylvainJuge? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b code-stacktrace upstream/code-stacktrace
git merge upstream/main
git push upstream code-stacktrace

Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kruskall kruskall merged commit a53b430 into elastic:main Jan 15, 2024
15 checks passed
@SylvainJuge SylvainJuge deleted the code-stacktrace branch January 15, 2024 15:28
@marclop marclop self-assigned this Mar 20, 2024
@marclop
Copy link
Contributor

marclop commented Mar 20, 2024

I verified this in ESS 8.13 latest BC. I modified sendotlp to set code.stacktrace as a span attribute.

@SylvainJuge is it expected that the code is only set in spans and not transactions?

image

@SylvainJuge
Copy link
Member Author

Yes, only spans should have code.stacktrace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan test-plan-ok v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants