Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rsync protect filter to preserve openapi spec #12987

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

kruskall
Copy link
Member

Motivation/summary

we're syncing docs spec from apm-data which causes rsync to delete the openapi spec because it's not in the target dir (apm-data). This PR adds a protect filter to prevent the openapi folder from being deleted.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

run make docs/spec
openapi spec should still be there

Related issues

Closes #12904

we're syncing docs spec from apm-data which causes rsync to delete the
openapi spec because it's not in the target dir (apm-data).
This PR adds a protect filter to prevent the openapi folder from being
deleted.
@kruskall kruskall requested a review from a team as a code owner April 17, 2024 12:53
Copy link
Contributor

mergify bot commented Apr 17, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 17, 2024
@@ -189,11 +189,6 @@ update-beats: update-beats-module update
update-beats-module:
$(GO) get -d $(BEATS_MODULE)@$(BEATS_VERSION) && $(GO) mod tidy

.PHONY: update-beats-docs
update-beats-docs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why this change? Does not seem related to the other change or with the linked issue to me, but I may lack the context. Could you clarify it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder doesn't exist anymore and the task is unused. The doc was moved in e0c42a5

@kruskall kruskall enabled auto-merge (squash) April 17, 2024 16:28
@kruskall kruskall merged commit 2ca24dd into elastic:main Apr 17, 2024
9 checks passed
@kruskall kruskall deleted the fix/protect-openapi branch April 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix automation, bring back openAPI spec
2 participants