Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15] Fix ScrollID used for retrieval of APM Agents configuration (backport #13958) #13980

Merged
merged 2 commits into from
Sep 9, 2024
Merged

[8.15] Fix ScrollID used for retrieval of APM Agents configuration (backport #13958) #13980

merged 2 commits into from
Sep 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 3, 2024

  • Fixed broken APM Agents configuration cache

Motivation/summary

APM Agents configuration cache appears to be broken, resulting frequent invalid requests made by APM Server to Elasticsearch cluster.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  1. Deploy Elastic Stack: Elasticsearch, Kibana, APM Server.
  2. Configure self-instrumentation for APM Server
  3. Open Kibana/APM
  4. Check APM Server has no failed operations of type "Elasticsearch: POST .apm-agent-configuration/_search" for Elasticsearch dependency

Related issues

closes #13957

This is an automatic backport of pull request #13958 done by [Mergify](https://mergify.com).

@up2neck @mergify
Fix agentcfg cache renewal scroll (#13958)
d8a4671 
APM Agents configuration cache appears to be broken, resulting frequent invalid requests made by APM Server to Elasticsearch cluster. Fix ScrollID used for retrieval of APM Agents configuration.

(cherry picked from commit ecffa8e)
@mergify mergify bot requested a review from a team as a code owner September 3, 2024 14:53
@mergify mergify bot added the backport label Sep 3, 2024
carsonip
carsonip requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only merge after 8.15.1 release

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Sep 9, 2024

This pull request has not been merged yet. Could you please review and merge it @? 🙏

@mergify mergify bot merged commit 1db3087 into 8.15 Sep 9, 2024
12 checks passed
@mergify mergify bot deleted the mergify/bp/8.15/pr-13958 branch September 9, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsonip carsonip carsonip approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsonip @up2neck