8.15: fix smoke tests

[endorama]

Motivation/summary

tags module was using the build input var, but it was not defined.
This was producing failures like:

Error: Reference to undeclared input variable

  on ../../infra/terraform/modules/tags/output.tf line 7, in locals:
   7:     "build" : var.build

An input variable with the name "build" has not been declared. This variable
can be declared with a variable "build" {} block.

Checklist

How to test these changes

Manually trigger Smoke Test workflow on this branch.

https://github.com/elastic/apm-server/actions/workflows/smoke-tests-schedule.yml

Related issues

[endorama]

Triggered smoke test run https://github.com/elastic/apm-server/actions/runs/11140665972

[marclop]

I think we need to merge this to main, and backport to 8.x, not open against 8.15.

[endorama]

@marclop On main this is correct (see here). The original PR wasn't backported, which is the source for these failures #13841

[kruskall]

shouldn't it also reference the var in https://github.com/v1v/apm-server/blob/3bc23c4eb4931033c41ff64238c9c8ae2924da7a/testing/infra/terraform/modules/tags/output.tf#L7 ?

fwiw you can backport a PR with @mergifyio backport <branch>

[endorama]

The previous run failed with the same error message, due to the way I triggered it. I triggered another run the should verify if this change works in https://github.com/elastic/apm-server/actions/runs/11147080061

(but it used the workflow file from main so I'm not sure it tests what I expect). Anyway if it don't pass I think it's safe to merge after @marclop confirm I address his concerns.

[endorama]

@kruskall no because 8.15 already has it. Anyway, as the tests are broken, I opened a backport PR, which makes clearer where this fix come from.

Closing as superseded by #14240 (the only difference is the docs)