Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] terraform: enable build tag (backport #13841) #14241

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2024

Motivation/summary

I'd like to honour the CI details so we can tag any cloud resources with the Build ID or so, this will help to identify if the resources were created when running the terraform locally or in the CI.

For instance, currently

image

Then when https://github.com/elastic/apm-aws-lambda/actions/workflows/smoke-tests.yml runs I wanna see

image

Or something similar

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #13841 done by [Mergify](https://mergify.com).

(cherry picked from commit b4c79b3)

# Conflicts:
#	testing/infra/terraform/modules/tags/output.tf
@mergify mergify bot requested a review from a team as a code owner October 2, 2024 16:25
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 2, 2024
Copy link
Contributor Author

mergify bot commented Oct 2, 2024

Cherry-pick of b4c79b3 has failed:

On branch mergify/bp/8.x/pr-13841
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit b4c79b3ab.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   testing/infra/terraform/modules/tags/output.tf

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned v1v Oct 2, 2024
@v1v v1v closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant