Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] tests: Add parallel monitoring middleware test (backport #14443) #14445

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 25, 2024

Motivation/summary

This PR adds concurrency test for the fix from #14335.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Test results from v8.15.2

=== RUN   TestMonitoringHandler
=== RUN   TestMonitoringHandler/Parallel
==================
WARNING: DATA RACE
Read at 0x00c000127050 by goroutine 24:
  runtime.mapassign_fast64ptr()
 ...
 ...
 ...

Previous write at 0x00c000127050 by goroutine 23:
  runtime.mapaccess2_faststr()
 ...
 ...
 ...

Goroutine 24 (running) created at:
 ...
 ...
 ...

Goroutine 23 (finished) created at:
 ...
 ...
 ...
==================

Test results from main

=== RUN   TestMonitoringHandler
=== RUN   TestMonitoringHandler/Parallel
--- PASS: TestMonitoringHandler (0.00s)
    --- PASS: TestMonitoringHandler/Parallel (0.00s)
PASS
ok  	github.com/elastic/apm-server/internal/beater/middleware	1.547s

Related issues

#14335


This is an automatic backport of pull request #14443 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 25, 2024 05:36
@mergify mergify bot added the backport label Oct 25, 2024
@mergify mergify bot assigned 1pkg Oct 25, 2024
@mergify mergify bot merged commit 8e0f017 into 8.16 Oct 25, 2024
13 checks passed
@mergify mergify bot deleted the mergify/bp/8.16/pr-14443 branch October 25, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant