[8.16] Test retry behavior of elasticsearch wrapper client (backport #14433) #14468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add es client retry test Test retry behaviour on our Elasticsearch client wrapper. We only want to retry on 429 status code, the test accounts for this specific behaviour and also verifies that other response code are not retried. * fix lint * remove unnecessary handlers * remove esMock struct Due to previous refactoring this is not needed anymore (cherry picked from commit 24d2222)
kruskall
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Test retry behaviour on our Elasticsearch client wrapper.
#13523 introduced a change in retry behavior, where only
429status code responses are retried. This is in line with expectations from Elasticsearch, as429is the only status code that guarantees a document to not have been indexed.This PR provides additional tests to cover for this change.
Checklist
For functional changes, consider:
How to test these changes
Go tests for
internal/elasticsearchpackage shold pass.Related issues
Rel: #13523
This is an automatic backport of pull request #14433 done by [Mergify](https://mergify.com).