Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump elastic-agent-libs and enable insecure defaults (backport #14956) #15039

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 23, 2024

Motivation/summary

to avoid breaking changes we call SetInsecureDefaults to allow tls 1.0 and 1.1

this PR doesn't change the defaults, the method is noop for now. In a future version (where we drop insecure tls versions) this method will allow choosing tls 1.0 and 1.1, thus avoiding the breaking change in 8.x

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Related to #10491


This is an automatic backport of pull request #14956 done by [Mergify](https://mergify.com).

* feat: bump elastic-agent-libs and enable insecure defaults

to avoid breaking changes we call SetInsecureDefaults to allow tls 1.0 and 1.1

* lint: update notice file

(cherry picked from commit a894c61)
@mergify mergify bot requested a review from a team as a code owner December 23, 2024 23:02
@kruskall
Copy link
Member

@Mergifyio queue

Copy link
Contributor Author

mergify bot commented Dec 23, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link
Contributor Author

mergify bot commented Dec 23, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@kruskall
Copy link
Member

@Mergifyio queue

Copy link
Contributor Author

mergify bot commented Dec 23, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 84f9260

@mergify mergify bot merged commit 84f9260 into 8.17 Dec 23, 2024
12 checks passed
@mergify mergify bot deleted the mergify/bp/8.17/pr-14956 branch December 23, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant