Add partial transaction spec for AWS lambda #799
Conversation
basepi
force-pushed
the
partial_transactions
branch
from
d56e93a
to
6148be7
Compare
| request ID) and the Content-Type should be | ||
| `application/vnd.elastic.apm.transaction+ndjson`. If the extension returns | ||
| anything other than a 200 HTTP code, the agent should stop sending partial | ||
| transaction registrations for future invocations. |
There was a problem hiding this comment.
This should say the request is a POST. Also the "should"s for the headers could be changed to "must"s.
POST /register/transaction
Content-Type: application/vnd.elastic.apm.transaction+ndjson
x-elastic-aws-request-id: ${awsRequestId}
{"metadata":{...}}
{"transaction":{...partial transaction data...}}
the metadata, if possible.
Is there a case where that isn't possible?
Some other notes I had regarding the transaction json blob:
It should have a default
outcomevalue.durationandresult(and possiblyoutcome) fields will be set by the Elastic Lambda extension if this transaction is used.
Not sure if we want this spec to record this info.
There was a problem hiding this comment.
This should say the request is a POST. Also the "should"s for the headers could be changed to "must"s.
Updated.
Is there a case where that isn't possible?
I removed that language. Perhaps someone is collecting the metadata asynchronously in some way? I'll leave it as a SHOULD -- in theory if an agent isn't ready with the metadata they could send it to the normal endpoint and the extension would record it. Pretty sure it's optional in @lahsivjar's implementation.
Not sure if we want this spec to record this info.
Is there a default outcome value? I don't think it's important to record here, I didn't change anything about python's to_dict() function that encodes the transaction dictionary (except to remove side effects).
There was a problem hiding this comment.
Is there a default
outcomevalue?
You are right, this spec section shouldn't mention outcome. The Node.js APM agent does set a default transaction.outcome of 'unknown', but the intake spec allows transaction.outcome to be null -- i.e. it is optional.
There was a problem hiding this comment.
Pretty sure it's optional in @lahsivjar's implementation.
Yes, metadata is optional.
| request ID) and the Content-Type should be | ||
| `application/vnd.elastic.apm.transaction+ndjson`. If the extension returns | ||
| anything other than a 200 HTTP code, the agent should stop sending partial | ||
| transaction registrations for future invocations. |
There was a problem hiding this comment.
Pretty sure it's optional in @lahsivjar's implementation.
Yes, metadata is optional.
I'm adding this spec after-the-fact, all relevant agents have already implemented this. Thus, I skipped the "draft" phase and went straight to final review.
This information is pulled from #753