Skip to content

Commit

Permalink
Do not cancel context on Connection.Close (#40769) (#40776)
Browse files Browse the repository at this point in the history
This commit removes a call to conn.cancelReqs() that causes the
Connection to be unusable after Close() is called, leading to the bug
described by #40705.

(cherry picked from commit b0e4f85)

Co-authored-by: Tiago Queiroz <[email protected]>
  • Loading branch information
mergify[bot] and belimawr authored Sep 12, 2024
1 parent ce2e931 commit 2f0dda8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion libbeat/esleg/eslegclient/connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ func (conn *Connection) Ping() (ESPingData, error) {
// Close closes a connection.
func (conn *Connection) Close() error {
conn.HTTP.CloseIdleConnections()
conn.cancelReqs()
return nil
}

Expand Down

0 comments on commit 2f0dda8

Please sign in to comment.