updated metrics.Close() logic to help with tests failing

elastic · Nov 6, 2024 · a16a176 · a16a176
1 parent 1a519f0
commit a16a176
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/x-pack/filebeat/input/gcs/metrics.go b/x-pack/filebeat/input/gcs/metrics.go
@@ -71,13 +71,12 @@ func newInputMetrics(id string, optionalParent *monitoring.Registry) *inputMetri
 		Register("histogram", metrics.NewHistogram(out.sourceLagTime)) //nolint:errcheck // A unique namespace is used so name collisions are impossible.
 
 	// set the URL of the input resource. Id is the bucket name.
-	if id != "" {
-		out.url.Set("gs://" + id)
-	}
+	out.url.Set("gs://" + id)
 
 	return out
 }
 
 func (m *inputMetrics) Close() {
+	m.url.Clear()
 	m.unregister()
 }