Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor from 0.8.0 to 0.11.0 #40597

Open
zmoog opened this issue Aug 23, 2024 · 1 comment
Open

Upgrade github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor from 0.8.0 to 0.11.0 #40597

zmoog opened this issue Aug 23, 2024 · 1 comment
Assignees
@zmoog
Labels
enhancement input:azure-monitor Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@zmoog
Copy link
Contributor

zmoog commented Aug 23, 2024

The github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/[email protected] package changes the signature of two functions adding an extra argument:

  • armmonitor.NewMetricsClient()
  • armmonitor.NewMetricDefinitionsClient()

It doesn't seem like a radical change, but we need to double-check whether the semantics have changed and run a few tests.
@zmoog zmoog added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team input:azure-monitor labels Aug 23, 2024
@zmoog zmoog self-assigned this Aug 23, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@zmoog zmoog mentioned this issue Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmoog zmoog

Labels
enhancement input:azure-monitor Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zmoog @elasticmachine