Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor from 0.8.0 to 0.11.0 #40412

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2024

Bumps github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor from 0.8.0 to 0.11.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner August 1, 2024 10:31
@dependabot dependabot bot added automation dependabot GitHub Dependabot labels Aug 1, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 1, 2024
Copy link
Contributor

mergify bot commented Aug 1, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @dependabot[bot]? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor-0.11.0 branch from b7c719c to cdedab2 Compare August 7, 2024 23:49
@zmoog zmoog self-assigned this Aug 12, 2024
@zmoog zmoog added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Aug 12, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 12, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@zmoog
Copy link
Contributor

zmoog commented Aug 12, 2024

The github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/[email protected] package changes the signature of two functions adding an extra argument:

  • armmonitor.NewMetricsClient()
  • armmonitor.NewMetricDefinitionsClient()

It doesn't seem a radical change, but we need to double-check if there's a change in the semantics and run a few tests.

Copy link
Contributor

mergify bot commented Aug 12, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor-0.11.0 upstream/dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor-0.11.0
git merge upstream/main
git push upstream dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor-0.11.0

…er/monitor/armmonitor

Bumps [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor](https://github.com/Azure/azure-sdk-for-go) from 0.8.0 to 0.11.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/azcore/v0.8.0...sdk/azcore/v0.11.0)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor-0.11.0 branch from 42034cb to 1a04f55 Compare August 12, 2024 19:53
@zmoog
Copy link
Contributor

zmoog commented Aug 23, 2024

I want to take some time to test this change before merging it. I created a dedicated issue #40597 for this purpose.

Closing this PR to free one of the Dependabot slots (we limited the number of PRs that Dependabot can open simultaneously).

@zmoog zmoog closed this Aug 23, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor-0.11.0 branch August 23, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation dependabot GitHub Dependabot Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants