Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] TestRateLimiter/Update_stops_requests_when_none_are_remaining #42059

Closed
belimawr opened this issue Dec 16, 2024 · 3 comments · Fixed by #42123
Closed

[Flaky Test] TestRateLimiter/Update_stops_requests_when_none_are_remaining #42059

belimawr opened this issue Dec 16, 2024 · 3 comments · Fixed by #42123
Assignees
@chrisberkhout
Labels
Filebeat Filebeat flaky-test Unstable or unreliable test cases. Team:Security-Service Integrations Security Service Integrations Team

Comments

@belimawr
Copy link
Contributor

Flaky Test

Stack Trace

2024-12-14 00:09:55 UTC	=== Failed
2024-12-14 00:09:55 UTC	=== FAIL: x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta TestRateLimiter/Update_stops_requests_when_none_are_remaining (1.02s)
2024-12-14 00:09:55 UTC	    ratelimiter_test.go:90: doesn't allow requests to resume after reset. had to wait 1.0242622s
2024-12-14 00:09:55 UTC	    ratelimiter_test.go:105: tokens don't accumulate at the expected rate over 30s: 30.024262
2024-12-14 00:09:55 UTC	
2024-12-14 00:09:55 UTC	=== FAIL: x-pack/filebeat/input/entityanalytics/provider/okta/internal/okta TestRateLimiter (1.02s)
@belimawr belimawr added the flaky-test Unstable or unreliable test cases. label Dec 16, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 16, 2024
@belimawr belimawr mentioned this issue Dec 16, 2024
Merged
11 tasks
@belimawr
Copy link
Contributor Author

I found another instance of this failure:

I'll mark the test ad flaky.

belimawr added a commit to belimawr/beats that referenced this issue Dec 19, 2024
@belimawr
Skip flaky test
79d2f44 
This test is flaky, see: elastic#42059
@belimawr belimawr mentioned this issue Dec 19, 2024
Merged
6 tasks
belimawr added a commit to belimawr/beats that referenced this issue Dec 19, 2024
@belimawr
Skip flaky test TestRateLimiter
336bf6d 
This test is flaky, see: elastic#42059
jlind23 pushed a commit that referenced this issue Dec 19, 2024
@belimawr
Skip flaky test TestRateLimiter (#42120)
df4832e 
This test is flaky, see: #42059
mergify bot pushed a commit that referenced this issue Dec 19, 2024
@belimawr @mergify
Skip flaky test TestRateLimiter (#42120)
2cae091 
This test is flaky, see: #42059

(cherry picked from commit df4832e)
@mergify mergify bot mentioned this issue Dec 19, 2024
Merged
6 tasks
@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations Team label Dec 19, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 19, 2024
@andrewkroh andrewkroh added Filebeat Filebeat and removed flaky-test Unstable or unreliable test cases. Team:Security-Service Integrations Security Service Integrations Team labels Dec 19, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 19, 2024
@andrewkroh andrewkroh added the Team:Security-Service Integrations Security Service Integrations Team label Dec 19, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 19, 2024
@andrewkroh andrewkroh added the flaky-test Unstable or unreliable test cases. label Dec 19, 2024
@andrewkroh
Copy link
Member

It failed on 8.x for me.

https://buildkite.com/elastic/beats-xpack-filebeat/builds/9164#0193dfa9-3cb5-41b6-bd96-4d206b972c8c/89-472

andrewkroh pushed a commit that referenced this issue Dec 19, 2024
@mergify @belimawr
Skip flaky test TestRateLimiter (#42120) (#42121)
55f18d7 
This test is flaky, see: #42059

(cherry picked from commit df4832e)

Co-authored-by: Tiago Queiroz <[email protected]>
@chrisberkhout chrisberkhout self-assigned this Dec 19, 2024
@chrisberkhout chrisberkhout mentioned this issue Dec 19, 2024
Merged
6 tasks
@mergify mergify bot mentioned this issue Dec 24, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisberkhout chrisberkhout

Labels
Filebeat Filebeat flaky-test Unstable or unreliable test cases. Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.../input/entityanalytics/provider/okta: Fix flaky tests chrisberkhout/elastic-beats
4 participants
@chrisberkhout @belimawr @andrewkroh @elasticmachine