Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.../input/entityanalytics/provider/okta: Fix flaky tests #42123

Merged
merged 3 commits into from
Dec 24, 2024
Merged

.../input/entityanalytics/provider/okta: Fix flaky tests #42123

merged 3 commits into from
Dec 24, 2024
+3 −2

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Dec 19, 2024 •
edited
Loading

Proposed commit message

.../input/entityanalytics/provider/okta: Fix flaky tests

In rate limiting tests by expanding the allowed ranges by 10x.

Earlier failures were double the allowed ranges:
  ratelimiter_test.go: doesn't allow requests to resume after reset. had to wait 1.0242622s
  ratelimiter_test.go: tokens don't accumulate at the expected rate over 30s: 30.024262

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None.

Related issues

@chrisberkhout chrisberkhout added flaky-test Unstable or unreliable test cases. cleanup Team:Security-Service Integrations Security Service Integrations Team labels Dec 19, 2024
@chrisberkhout chrisberkhout self-assigned this Dec 19, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner December 19, 2024 16:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @chrisberkhout? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 19, 2024
efd6
efd6 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changelog fixed.

This looks like it might be related to go.dev/issue/44343.

CHANGELOG-developer.next.asciidoc Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented Dec 19, 2024

/test

@ShourieG
Copy link
Contributor

Merging on behalf of @chrisberkhout

@ShourieG ShourieG merged commit 9b92245 into elastic:main Dec 24, 2024
20 of 22 checks passed
mergify bot pushed a commit that referenced this pull request Dec 24, 2024
@chrisberkhout @mergify
.../input/entityanalytics/provider/okta: Fix flaky tests (#42123)
f63275e 
* Fix flaky tests by expanding allowed range by 10x.

* CHANGELOG-developer.next.asciidoc entry.

* Update CHANGELOG-developer.next.asciidoc

Co-authored-by: Dan Kortschak <[email protected]>

---------

Co-authored-by: ShourieG <[email protected]>
Co-authored-by: Dan Kortschak <[email protected]>
(cherry picked from commit 9b92245)
@mergify mergify bot mentioned this pull request Dec 24, 2024
Merged
6 tasks
ShourieG pushed a commit that referenced this pull request Dec 24, 2024
@mergify @chrisberkhout
.../input/entityanalytics/provider/okta: Fix flaky tests (#42123) (#4…
5b3186f 
…2149)

* Fix flaky tests by expanding allowed range by 10x.

* CHANGELOG-developer.next.asciidoc entry.

* Update CHANGELOG-developer.next.asciidoc

Co-authored-by: Dan Kortschak <[email protected]>

---------

Co-authored-by: ShourieG <[email protected]>
Co-authored-by: Dan Kortschak <[email protected]>
(cherry picked from commit 9b92245)

Co-authored-by: Chris Berkhout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@chrisberkhout chrisberkhout

Labels
backport-8.x Automated backport to the 8.x branch with mergify cleanup flaky-test Unstable or unreliable test cases. Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky Test] TestRateLimiter/Update_stops_requests_when_none_are_remaining
4 participants
@chrisberkhout @elasticmachine @efd6 @ShourieG