Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packetbeat/beater: make Npcap installation lazy #35935

Merged
merged 4 commits into from
Aug 1, 2023
Merged

packetbeat/beater: make Npcap installation lazy #35935

merged 4 commits into from
Aug 1, 2023

Commits on Jul 30, 2023

  1. packetbeat/beater: make Npcap installation lazy 

    In the fleet-managed case New is called without a complete config, which means
that we have no stream to tell us not to install the Npcap DLL.

Defer installation until we have a valid config with streams configured so that
we can determine whether the user has blocked install and whether we need the DLL.
    @efd6
    efd6 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    491853d View commit details
    Browse the repository at this point in the history

  2. address pr comment

    @efd6
    efd6 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    2c0f85c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. add logging to decision path

    @efd6
    efd6 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    bda92fa View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. alter never install behaviour to allow install if no Npcap DLL is alr… 

    …eady installed
    @efd6
    efd6 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    55ad07f View commit details
    Browse the repository at this point in the history