Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/entityanalytics/provider/okta: add device handling #36049

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 12, 2023

What does this PR do?

This adds support for device entities to the Okta API entity analytics provider.

Why is it important?

Milestone task.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.10-candidate labels Jul 12, 2023
@efd6 efd6 self-assigned this Jul 12, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 12, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-14T09:25:24.749+0000

  • Duration: 78 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 3132
Skipped 176
Total 3308

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 force-pushed the st6908-okta-device-provider branch 5 times, most recently from 5d58d30 to 96c6e40 Compare July 12, 2023 23:03
@mergify

This comment was marked as outdated.

@efd6 efd6 force-pushed the st6908-okta-device-provider branch from 96c6e40 to 4ae9778 Compare July 14, 2023 01:42
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b st6908-okta-device-provider upstream/st6908-okta-device-provider
git merge upstream/main
git push upstream st6908-okta-device-provider

@efd6 efd6 force-pushed the st6908-okta-device-provider branch from 4ae9778 to 370fdbe Compare July 18, 2023 07:21
@mergify

This comment was marked as outdated.

@efd6 efd6 force-pushed the st6908-okta-device-provider branch from 370fdbe to 48d2e89 Compare July 23, 2023 22:13
@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b st6908-okta-device-provider upstream/st6908-okta-device-provider
git merge upstream/main
git push upstream st6908-okta-device-provider

@efd6 efd6 force-pushed the st6908-okta-device-provider branch from 48d2e89 to eb1035b Compare July 27, 2023 02:07
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b st6908-okta-device-provider upstream/st6908-okta-device-provider
git merge upstream/main
git push upstream st6908-okta-device-provider

@efd6 efd6 force-pushed the st6908-okta-device-provider branch 3 times, most recently from 3512daf to 86e6070 Compare August 10, 2023 08:55
@efd6 efd6 marked this pull request as ready for review August 10, 2023 08:57
@efd6 efd6 requested a review from a team as a code owner August 10, 2023 08:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@mergify

This comment was marked as outdated.

@efd6 efd6 force-pushed the st6908-okta-device-provider branch from 86e6070 to a18b742 Compare August 13, 2023 21:03
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@mergify

This comment was marked as outdated.

@efd6 efd6 force-pushed the st6908-okta-device-provider branch from a18b742 to f01adb1 Compare August 14, 2023 09:25
@efd6 efd6 merged commit 241b459 into elastic:main Aug 14, 2023
6 of 8 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.10-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants