-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ndjson parser to store JSON fields correctly under target
#36089
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
/test |
/test |
@zipperle Left a minor comment about the CHANGELOG entry. Also, I rebased this PR on |
@ycombinator thanks for the hint, I moved the changelog entry accordingly. |
/test |
/test |
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution, @zipperle!
* Fix ndjson parser to store JSON fields correctly under target * Update CHANGELOG.next.asciidoc * Move the change log entry to the right section --------- Co-authored-by: Shaunak Kashyap <[email protected]> (cherry picked from commit 2aba00a)
…tic#36089) * Fix ndjson parser to store JSON fields correctly under target * Update CHANGELOG.next.asciidoc * Move the change log entry to the right section --------- Co-authored-by: Shaunak Kashyap <[email protected]>
What does this PR do?
Stores the JSON fields in a nested way if the
target
of the ndjson parser contains a dotted key, e.g.the following config:
leads to this result:
instead of this:
Why is it important?
Fixes unexpected behavior.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Tested with a unit test.
Related issues
target
#29395Use cases
Screenshots
Logs