Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[functionbeat] Fix deployment for CloudWatch Logs function type #36305

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gemabarni
Copy link
Contributor

@gemabarni gemabarni commented Aug 12, 2023

Proposed commit message

AWS CloudFormation started validating CloudWatch's permission to invoke a Lambda function when deploying a subscription filter, which could result in Functionbeat deployment errors: #33173. Although no AWS documentation states this explicitly, all of their official guides imply that the permission should always be created first. Examples:

This PR introduces a dependency between the two entities to make sure that the permission is already present when the subscription filter gets deployed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@gemabarni gemabarni requested a review from a team as a code owner August 12, 2023 15:31
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 12, 2023
@botelastic
Copy link

botelastic bot commented Aug 12, 2023

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gemabarni? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-14T08:49:17.566+0000

  • Duration: 48 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 489
Skipped 6
Total 495

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-logs-deploy upstream/fix-logs-deploy
git merge upstream/main
git push upstream fix-logs-deploy

@jonathan-franzen
Copy link

When will this get merged? I have major issues with my deployment

@dgsamper
Copy link

Our deploy was impacted by this too. We actually had to deploy with just one log group, and add the others manually, to be able to work. Any plans on merging this PR or no more support for functionbeat?

Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gemabarni? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

functionbeat - Could not execute the lambda function
6 participants