-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[functionbeat] Fix deployment for CloudWatch Logs function type #36305
base: main
Are you sure you want to change the base?
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
ce356f3
to
d3872bd
Compare
d3872bd
to
a5cbccd
Compare
When will this get merged? I have major issues with my deployment |
Our deploy was impacted by this too. We actually had to deploy with just one log group, and add the others manually, to be able to work. Any plans on merging this PR or no more support for functionbeat? |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Proposed commit message
AWS CloudFormation started validating CloudWatch's permission to invoke a Lambda function when deploying a subscription filter, which could result in Functionbeat deployment errors: #33173. Although no AWS documentation states this explicitly, all of their official guides imply that the permission should always be created first. Examples:
This PR introduces a dependency between the two entities to make sure that the permission is already present when the subscription filter gets deployed.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues