-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat][Kubernetes] Add metricset for state_namespace #36406
Changes from 6 commits
23321a9
443805c
7c85573
e8adb2b
b846be7
5fe0b2f
9ca7330
dc5add7
5e3edf5
2fadbd0
f5d758b
57242e9
eb4a063
039f002
1c19a3d
b120c82
cf927b4
511913c
add12fe
5221f0b
e559998
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"@timestamp": "2019-03-01T08:05:34.853Z", | ||
"event": { | ||
"dataset": "kubernetes.state_namespace", | ||
"duration": 115000, | ||
"module": "kubernetes" | ||
}, | ||
"kubernetes": { | ||
"namespace": "default", | ||
"state_namespace": { | ||
"created": { | ||
"sec": 1691566338 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
} | ||
}, | ||
"metricset": { | ||
"name": "state_namespace", | ||
"period": 10000 | ||
}, | ||
"service": { | ||
"address": "127.0.0.1:55555", | ||
"type": "kubernetes" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
- name: state_namespace | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer a name like Note that I'm only referring to the fields' prefix and not the name of the metricset. The name of the metricset is just fine as is. But maybe we can improve the field's naming with what I mention. @mlunadia do you have any preference here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gizas since you were the one suggesting this name, what do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am also +1 for using |
||
type: group | ||
release: ga | ||
description: > | ||
Kubernetes namespace metrics. | ||
fields: | ||
- name: created.sec | ||
type: double | ||
description: > | ||
Unix creation timestamp. | ||
- name: status | ||
type: group | ||
fields: | ||
- name: active | ||
type: boolean | ||
description: Whether the namespace is active (true or false). | ||
- name: terminating | ||
type: boolean | ||
description: Whether the namespace is terminating (true or false). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,127 @@ | ||
[ | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "kube-node-lease" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879559 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.state_namespace", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "default" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879561 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.state_namespace", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "kube-public" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879559 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.state_namespace", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "local-path-storage" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879567 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.state_namespace", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "kube-system" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879559 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.state_namespace", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems you pushed local changes for this file, could you please revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Is it ok now with just
state_namespace
added?