Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][ingest-processors] Updated Example in Docs of append processor #36478

Merged
merged 3 commits into from
Sep 8, 2023
Merged

[docs][ingest-processors] Updated Example in Docs of append processor #36478

merged 3 commits into from
Sep 8, 2023

Conversation

vinit-chauhan
Copy link
Contributor

Proposed commit message

The PR here is to update the example in the append processor in libbeat. The example in the existing doc is ambiguous.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner August 31, 2023 18:43
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @vinit-chauhan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 31, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-01T20:48:54.090+0000

  • Duration: 9 min 57 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 1, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 1, 2023
kilfoyle
kilfoyle reviewed Sep 1, 2023
View reviewed changes
libbeat/processors/actions/docs/append.asciidoc Outdated
- static-value
- ""
ignore_missing: true
fail_on_error: true
ignore_empty_values: true
------------------------------------------------------------------------------

Copies the values of `concrete.field`, `array.one` from response field to `my-target-field`:
Copies the values of `concrete.field`, `array.one` response field and the static values from to `target-field`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a word missing after the static values from?

kilfoyle
kilfoyle approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinit-chauhan
Copy link
Contributor Author

Hey @kilfoyle - Would you please add appropriate backport tags as well? AFAIK, the feature was merged and released for 8.7.

pierrehilbert
pierrehilbert approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierrehilbert pierrehilbert added backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify backport-v8.10.0 Automated backport with mergify labels Sep 5, 2023
@kilfoyle
Copy link
Contributor

kilfoyle commented Sep 5, 2023

Hey @kilfoyle - Would you please add appropriate backport tags as well? AFAIK, the feature was merged and released for 8.7.

Thanks to Pierre the backport tags are all set now. :-)

@pierrehilbert pierrehilbert merged commit 9ca9434 into elastic:main Sep 8, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Sep 8, 2023
@vinit-chauhan @mergify
[docs][ingest-processors] Updated Example in Docs of append processor (…
8e02d0a 
…#36478)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)
@mergify mergify bot mentioned this pull request Sep 8, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 8, 2023
@vinit-chauhan @mergify
[docs][ingest-processors] Updated Example in Docs of append processor (…
35a7e46 
…#36478)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)
@mergify mergify bot mentioned this pull request Sep 8, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 8, 2023
@vinit-chauhan @mergify
[docs][ingest-processors] Updated Example in Docs of append processor (…
a98c9db 
…#36478)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)
@mergify mergify bot mentioned this pull request Sep 8, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 8, 2023
@vinit-chauhan @mergify
[docs][ingest-processors] Updated Example in Docs of append processor (…
fc86d5a 
…#36478)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)
@mergify mergify bot mentioned this pull request Sep 8, 2023
Merged
rdner pushed a commit that referenced this pull request Sep 14, 2023
@mergify @vinit-chauhan
[docs][ingest-processors] Updated Example in Docs of append processor (…
9eeb5a5 
…#36478) (#36542)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)

Co-authored-by: Vinit Chauhan <[email protected]>
rdner pushed a commit that referenced this pull request Sep 14, 2023
@mergify @vinit-chauhan
[docs][ingest-processors] Updated Example in Docs of append processor (…
4263f22 
…#36478) (#36543)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)

Co-authored-by: Vinit Chauhan <[email protected]>
rdner pushed a commit that referenced this pull request Sep 14, 2023
@mergify @vinit-chauhan
[docs][ingest-processors] Updated Example in Docs of append processor (…
b07218a 
…#36478) (#36545)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)

Co-authored-by: Vinit Chauhan <[email protected]>
pierrehilbert pushed a commit that referenced this pull request Nov 7, 2023
@mergify @vinit-chauhan
[docs][ingest-processors] Updated Example in Docs of append processor (…
85ec528 
…#36478) (#36544)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation

(cherry picked from commit 9ca9434)

Co-authored-by: Vinit Chauhan <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@vinit-chauhan @Scholar-Li
[docs][ingest-processors] Updated Example in Docs of append processor (…
aa82cb3 
…elastic#36478)

* Updated Example in Docs of append processor

* Reworded the sentence in documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@vinit-chauhan vinit-chauhan

Labels
backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify backport-v8.10.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinit-chauhan @elasticmachine @kilfoyle @pierrehilbert