Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9](backport #36399) Remove 'onFilteredOut' and 'onDroppedOnPublish' callback logs #36486

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 1, 2023

This is an automatic backport of pull request #36399 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

The 'onFilteredOut' and 'onDroppedOnPublish' callbacks debug logs can
cause an infinity loop of log entries being logged over and over again
when running under Elastic-Agent. Those log entries are removed to
prevent this from happening in the future.

The monitoring Filebeat uses a drop processor to drop its own logs,
however if log level is debug the `onFilteredOut` callback debug log
will log all dropped events, because it is done by the monitoring
Filebeat, it will be picked up, dropped and logged again, creating
this infinity loop.

(cherry picked from commit dde4079)
@mergify mergify bot requested a review from a team as a code owner September 1, 2023 12:07
@mergify mergify bot requested review from rdner and fearful-symmetry and removed request for a team September 1, 2023 12:07
@mergify mergify bot added the backport label Sep 1, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 1, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 1, 2023

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-01T12:07:22.358+0000

  • Duration: 76 min 31 sec

Test stats 🧪

Test Results
Failed 2
Passed 27509
Skipped 2024
Total 29535

Test errors 2

Expand to view the tests failures

Build&Test / libbeat-unitTest / test_zsh_completion – libbeat.tests.system.test_cmd_completion.TestCommandCompletion
    Expand to view the error details

     AssertionError: assert False
     +  where False = <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>>('#compdef _mockbeat mockbeat')
     +    where <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>> = <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>.log_contains 
    

    Expand to view the stacktrace

     self = <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>
    
        def test_zsh_completion(self):
            exit_code = self.run_beat(extra_args=["completion", "zsh"])
            assert exit_code == 0
    >       assert self.log_contains("#compdef _mockbeat mockbeat")
    E       AssertionError: assert False
    E        +  where False = <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>>('#compdef _mockbeat mockbeat')
    E        +    where <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>> = <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>.log_contains
    
    tests/system/test_cmd_completion.py:20: AssertionError 
    

Build&Test / libbeat-pythonIntegTest / test_zsh_completion – libbeat.tests.system.test_cmd_completion.TestCommandCompletion
    Expand to view the error details

     AssertionError: assert False
     +  where False = <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>>('#compdef _mockbeat mockbeat')
     +    where <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>> = <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>.log_contains 
    

    Expand to view the stacktrace

     self = <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>
    
        def test_zsh_completion(self):
            exit_code = self.run_beat(extra_args=["completion", "zsh"])
            assert exit_code == 0
    >       assert self.log_contains("#compdef _mockbeat mockbeat")
    E       AssertionError: assert False
    E        +  where False = <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>>('#compdef _mockbeat mockbeat')
    E        +    where <bound method TestCase.log_contains of <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>> = <test_cmd_completion.TestCommandCompletion testMethod=test_zsh_completion>.log_contains
    
    tests/system/test_cmd_completion.py:20: AssertionError 
    

Steps errors 8

Expand to view the steps failures

libbeat-unitTest - mage build unitTest
  • Took 5 min 5 sec . View more details here
  • Description: mage build unitTest
libbeat-unitTest - mage build unitTest
  • Took 2 min 58 sec . View more details here
  • Description: mage build unitTest
libbeat-unitTest - mage build unitTest
  • Took 2 min 58 sec . View more details here
  • Description: mage build unitTest
libbeat-pythonIntegTest - mage pythonIntegTest
  • Took 6 min 17 sec . View more details here
  • Description: mage pythonIntegTest
libbeat-pythonIntegTest - mage pythonIntegTest
  • Took 3 min 43 sec . View more details here
  • Description: mage pythonIntegTest
libbeat-pythonIntegTest - mage pythonIntegTest
  • Took 3 min 41 sec . View more details here
  • Description: mage pythonIntegTest
metricbeat-unitTest - mage build unitTest
  • Took 5 min 32 sec . View more details here
  • Description: mage build unitTest
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 1, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 1, 2023
@mergify
Copy link
Contributor Author

mergify bot commented Sep 4, 2023

This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏

@belimawr
Copy link
Contributor

belimawr commented Sep 5, 2023

Closing because we already have the 8.10 branch.

@belimawr belimawr closed this Sep 5, 2023
@mergify mergify bot deleted the mergify/bp/8.9/pr-36399 branch September 5, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants