-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packetbeat/protos/http] fix: non-standard http host format error and add extract host tests. #36498
Conversation
- Add test for `extractHostHeader` function
💚 CLA has been signed |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Thank you for your contribution. Can you please sign the CLA agreement for contributors for CI to proceed running your change. - Contributor Agreement |
/test |
Hi, I'm already signed and passed the CI test. |
Thanks @moonD4rk beats/CHANGELOG-developer.next.asciidoc Line 88 in 1209bca
|
/test |
/test |
Proposed commit message
fix: non-standard http host format when packetbeat capture http request and add extract host test cases.
extractHostHeader
functionChecklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
check and use
go test -v ./...
Related issues
Use cases
Packetbeat panic when HTTP requests that have a non-standard Host header. such as
:1234
TestCase
use
go test -v ./...
before:
after:
Screenshots
Logs