Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/httpjson: post-refactor clean-up #36520

Merged
merged 7 commits into from
Sep 7, 2023
Merged

x-pack/filebeat/input/httpjson: post-refactor clean-up #36520

merged 7 commits into from
Sep 7, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 6, 2023 •
edited
Loading

Proposed commit message

This change makes largely non-semantic changes to the package to clarify the behaviour of the components, but also makes some minor optimisations to reduce allocations.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Review commit-wise.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Filebeat Filebeat cleanup Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.11-candidate labels Sep 6, 2023
@efd6 efd6 self-assigned this Sep 6, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 6, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 6, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-06T20:57:08.297+0000

  • Duration: 74 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 3168
Skipped 176
Total 3344

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review September 6, 2023 22:21
@efd6 efd6 requested a review from a team as a code owner September 6, 2023 22:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit b0878a9 into elastic:main Sep 7, 2023
7 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
x-pack/filebeat/input/httpjson: post-refactor clean-up (elastic#36520)
ecb5430 
* fix valid lint complaints
* adjust labels to new semantics
* avoid context allocations during splits
* standardise context parameter naming
* avoid fruitless map allocation
* document handlers
* scattered cleanup
* logs last
* single line signatures
* reduce name stutter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify cleanup Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh