[add_session_metadata processor] Keep exited processes in the process DB #39173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the add_session_metadata processor, don't remove processes from the process db when the process has exited. The processor can be run on an fork/exec events after the process has actually exited, so the process must remain in the DB after it has exited, so the info can be used in enrichment of these events. Now the process is kept in the DB, and the exit code is appended, so the exit code is also now properly enriched for exit events.
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
mjwolf
added
bugfix
backport-v8.14.0
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
… DB (#39173) With the add_session_metadata processor, don't remove processes from the process db when the process has exited. The processor can be run on an fork/exec events after the process has actually exited, so the process must remain in the DB after it has exited, so the info can be used in enrichment of these events. Now that the process is kept in the DB, the exit code is also appended on exit events, so the exit code can be used in enrichment of the exit events. (cherry picked from commit 9649588)
6 tasks
mjwolf
added a commit
that referenced
this pull request
Apr 25, 2024
… DB (#39173) (#39225) With the add_session_metadata processor, don't remove processes from the process db when the process has exited. The processor can be run on an fork/exec events after the process has actually exited, so the process must remain in the DB after it has exited, so the info can be used in enrichment of these events. Now that the process is kept in the DB, the exit code is also appended on exit events, so the exit code can be used in enrichment of the exit events. (cherry picked from commit 9649588) Co-authored-by: Michael Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
With the add_session_metadata processor, don't remove processes from the process db when the process has exited.
The processor can be run on an fork/exec events after the process has actually exited, so the process must remain in the DB after it has exited, so the info can be used in enrichment of these events.
Now that the process is kept in the DB, the exit code is also appended on exit events, so the exit code can be used in enrichment of the exit events.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues