-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auditbeat pipeline to match Jenkins steps #39245
Update auditbeat pipeline to match Jenkins steps #39245
Conversation
b5023e4
to
23fd2a0
Compare
412a4c4
to
607b29e
Compare
9237ec7
to
8b8c2ff
Compare
23a3204
to
666f532
Compare
fix(auditbeat/fim/kprobes): allow appropriate syscalls for seccomp/apparmor policies fix(tests/system): remove check on absent key of the event
This reverts commit e985f41.
and resolve conflicts
@oakrizan as you're on PTO, I updated this PR with some minimal comments/changes and re:
I've reverted muting the tests for both as it should be done after consulting the corresponding teams. For 2. @pkoutsovasilis raised a fix, which we tested with this PR by cherry-picking his fix in 907f94a . With that, the tests succeeded: https://buildkite.com/elastic/auditbeat/builds/4581#018f3896-f533-4678-af93-acac60fc452b/147-150 . I will revert the commit before merging, as it should be fixed via a separate PR that @pkoutsovasilis will raise. For 1. I raised the attention on https://github.com/elastic/ingest-dev/issues/3270 which will be looked at by the corresponding team. |
…causes losing events on mac
@pkoutsovasilis also raised a fix for this pkoutsovasilis@eabfda2 which appears to have resolved the macOS failures: https://buildkite.com/elastic/auditbeat/builds/4593#018f3900-f651-42e4-bc2f-d62a14092e22 |
This pull request is now in conflicts. Could you fix it? 🙏
|
With the fixes for macOS and auditbeat integration tests by @pkoutsovasilis cherry picked, all tests (using the labels https://buildkite.com/elastic/beats/builds/6929 [^1] except Linux packaging for |
Now that the test fixes have been raised in separate PRs: #39362 / #39361, I've reverted the cherry picks #39245 (commits) so that this is a clean PR related to Buildkite auditbeat fixes only. Once (basic) CI is green, I'll merge it and begin the backport process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on #39245 (comment)
This commit updates the `auditbeat` pipeline to match same steps & commands as in Jenkins. Relates: https://github.com/elastic/ingest-dev/issues/3254 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c1663a3)
This commit updates the `auditbeat` pipeline to match same steps & commands as in Jenkins. Relates: https://github.com/elastic/ingest-dev/issues/3254 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c1663a3)
This commit updates the `auditbeat` pipeline to match same steps & commands as in Jenkins. Relates: https://github.com/elastic/ingest-dev/issues/3254 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c1663a3)
This commit updates the `auditbeat` pipeline to match same steps & commands as in Jenkins. Relates: https://github.com/elastic/ingest-dev/issues/3254 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c1663a3) Co-authored-by: Olga Naydyonock <[email protected]>
This commit updates the `auditbeat` pipeline to match same steps & commands as in Jenkins. Relates: https://github.com/elastic/ingest-dev/issues/3254 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c1663a3)
This commit updates the `auditbeat` pipeline to match same steps & commands as in Jenkins. Relates: https://github.com/elastic/ingest-dev/issues/3254 --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c1663a3)
Proposed commit message
In scope of https://github.com/elastic/ingest-dev/issues/3254 - updated auditbeat pipeline to match same steps & commands as in Jenkins.
Jenkins vs. Buildkite comparison: https://gist.github.com/oakrizan/3af834fc51eabf9b9b8b910133886320
BK builds: https://buildkite.com/elastic/auditbeat/builds?branch=oakrizan%3Aauditbeat-postmigration-fixes
MacOS test failure is not related to current PR (more details in gist).
MacOS TMP folder error issue - https://github.com/elastic/ingest-dev/issues/3268
Intgration test timeout error issue - https://github.com/elastic/ingest-dev/issues/3270
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs