-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.14](backport #38534) [DOCS] Add the read_pipeline
cluster privilege to winlogbeat documentation
#39491
Merged
Merged
[8.14](backport #38534) [DOCS] Add the read_pipeline
cluster privilege to winlogbeat documentation
#39491
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e7b8c36
[DOCS] Add the `read_pipeline` cluster privilege for winlogbeat and t…
herrBez e3f0d10
Merge branch '8.14' into mergify/bp/8.14/pr-38534
pierrehilbert 66031aa
Merge branch '8.14' into mergify/bp/8.14/pr-38534
pierrehilbert 3293233
Update users.asciidoc to fix the rendeing issue
herrBez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would render like the following:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@herrBez The suggestion above will add those
+
signs, if I understand correctly that that's what should be changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I want it to render to (e.g.,
filebeat-*
). How can I achieve that :)? ASCIIDoc and variables are not my forte.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I'm sorry! I misunderstood. I don't work with Beats much so I missed that
{beat_default_index_prefix}
is a variable. Variables won't be interpolated when they're inside backticks. So, I think the best we can do here is to take them out, like this:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I guess I got it (it should be the same as on the one on the right). How are you doing the rendering ? (To avoid this problem in the future :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My pleasure Mirko! It looks good now.
To do the local rendering, you can:
Then, use any of the aliases in that file with
--open
. For example:docbldfb --open
- generates the Filebeat docsdocbldim --open
- generates the Fleet & Agent GuideMost docs builds take just a minute or two. The largest, for Elasticsearch docs (dodbldes --open) takes about five minutes.