Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update elastic-agent-libs to v0.9.11 #39765

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented May 29, 2024

Proposed commit message

Update elastic-agent-libs to v0.9.11 and add tests to ensure Beats always logs as JSON to a file when no logging is explicitly configured.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None, it's a bug fix.

## Author's Checklist

How to test this PR locally

  1. Build any Beat from this PR branch
  2. Run it with no logging configuration set
  3. Ensure the default log file is created.

You can also run the integration test added:

mage buildSystemTestBinary && go test -count=1 -tags=integration -run=TestFilebeatRunsAndLogs -v ./tests/integration

If you want to see the test failing before the fix, downgrade elastic-agent-libs

go get -u github.com/elastic/[email protected]

Then run the testt

## Related issues
## Use cases
## Screenshots
## Logs

@belimawr belimawr added bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels May 29, 2024
@belimawr belimawr requested review from a team as code owners May 29, 2024 20:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 29, 2024
Copy link
Contributor

mergify bot commented May 29, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@belimawr belimawr requested a review from faec May 30, 2024 12:22
@belimawr belimawr marked this pull request as draft May 30, 2024 12:36
@belimawr
Copy link
Contributor Author

Converting into draft until elastic/elastic-agent-libs#209 gets merged and I can update this PR to use v0.9.10

@belimawr belimawr changed the title update elastic-agent-libs to v0.9.9 update elastic-agent-libs to v0.9.10 May 30, 2024
@belimawr belimawr marked this pull request as ready for review May 30, 2024 13:13
@belimawr belimawr marked this pull request as draft May 30, 2024 19:54
@belimawr
Copy link
Contributor Author

I found another issue, back to draft until elastic/elastic-agent-libs#210 gets merged

Update elastic-agent-libs to v0.9.9 and add tests to ensure Beats
always logs as JSON to a file when no logging is explicitly
configured.
@belimawr belimawr marked this pull request as ready for review June 3, 2024 13:43
@belimawr belimawr changed the title update elastic-agent-libs to v0.9.10 update elastic-agent-libs to v0.9.11 Jun 3, 2024
@belimawr belimawr merged commit df064b8 into elastic:main Jun 3, 2024
106 of 107 checks passed
shmsr pushed a commit to shmsr/beats that referenced this pull request Jun 4, 2024
Update elastic-agent-libs to v0.9.11 and add tests to ensure Beats
always logs as JSON to a file when no logging is explicitly
configured.

An integration test is added to assert the behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants