Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #39860) filebeat: Fix flaky test case on macOS #39897

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 13, 2024

Proposed commit message

This PR fixes following test cases which are flaky for macOS:

  • tests/system/test_harvester.py::Test::test_debug_reader
  • tests/system/test_crawler.py::Test::test_tail_files
  • tests/system/test_crawler.py::Test::test_encodings
  • tests/system/test_registrar.py::Test::test_restart_state_reset_ttl_no_clean_inactive
  • tests/system/test_registrar.py::Test::test_restart_state_reset
  • tests/system/test_registrar.py::Test::test_restart_state
  • tests/system/test_registrar.py::Test::test_registry_file_update_permissions
  • tests/system/test_shutdown.py::Test::test_shutdown

On MacOS, the FQDN lookup takes some time (~5 seconds) before signal handlers are set up

  • the lingering FQDN lookup code is here
    To make sure that the tests are passed, we need to increase the timeout by few seconds in each of the failing cases.

You can view the full discussion https://elastic.slack.com/archives/C047NDNGUMU/p1717091056290869.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes #39613


This is an automatic backport of pull request #39860 done by Mergify.

* fix: fix a flaky test on macos

* fix: fix more such test cases

* fix: only update ignore_older

* fix: also fix flaky test_restart_state

* fix: fix CI

(cherry picked from commit f9fec1e)
@mergify mergify bot requested a review from a team as a code owner June 13, 2024 13:29
@mergify mergify bot added the backport label Jun 13, 2024
@mergify mergify bot requested review from faec and leehinman and removed request for a team June 13, 2024 13:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 13, 2024
@botelastic
Copy link

botelastic bot commented Jun 13, 2024

This pull request doesn't have a Team:<team> label.

@pierrehilbert pierrehilbert merged commit 6c3500f into 8.14 Jun 14, 2024
18 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.14/pr-39860 branch June 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants