-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Fix testing pipeline for Windows #40583
Conversation
…ints in the include file
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
@elastic/ingest-eng-prod could you provide a review? Thanks! |
@@ -111,7 +111,7 @@ steps: | |||
|
|||
- label: ":windows: x-pack/heartbeat: Win 2016 Unit Tests" | |||
key: "mandatory-win-2016-unit-tests" | |||
skip: "skipping due to elastic/beats#23957 and elastic/beats#23958" | |||
skip: "skipping due missing deps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a tracking issue for these missing dependencies to have a future reference?
Because we are still skipping them, and given that, I assume the other two are not related anymore?
@elastic/ingest-eng-prod could you provide a review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fix windows test pipeline by reflecting browser monitor build constraints in the include file
Proposed commit message
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
N/A
How to test this PR locally
mage update
and checkx-pack/heartbeat/include/list.go
is constrained tolinux || darwin || synthetics
build tags.Related issues
Closes #40502.