Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Fix testing pipeline for Windows #40583

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Aug 22, 2024

Fix windows test pipeline by reflecting browser monitor build constraints in the include file

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

N/A

How to test this PR locally

  • Run mage update and check x-pack/heartbeat/include/list.go is constrained to linux || darwin || synthetics build tags.

Related issues

Closes #40502.

@emilioalvap emilioalvap added Team:obs-ds-hosted-services Label for the Observability Hosted Services team ci labels Aug 22, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner August 22, 2024 13:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 22, 2024
Copy link
Contributor

mergify bot commented Aug 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@emilioalvap emilioalvap added the backport-skip Skip notification from the automated backport with mergify label Aug 22, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner August 22, 2024 14:01
@emilioalvap emilioalvap enabled auto-merge (squash) August 26, 2024 16:50
@emilioalvap
Copy link
Collaborator Author

@elastic/ingest-eng-prod could you provide a review? Thanks!

@alexsapran alexsapran self-requested a review August 28, 2024 10:34
@@ -111,7 +111,7 @@ steps:

- label: ":windows: x-pack/heartbeat: Win 2016 Unit Tests"
key: "mandatory-win-2016-unit-tests"
skip: "skipping due to elastic/beats#23957 and elastic/beats#23958"
skip: "skipping due missing deps"
Copy link
Contributor

@alexsapran alexsapran Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a tracking issue for these missing dependencies to have a future reference?
Because we are still skipping them, and given that, I assume the other two are not related anymore?

@emilioalvap emilioalvap requested review from alexsapran and a team August 28, 2024 15:13
@emilioalvap
Copy link
Collaborator Author

@elastic/ingest-eng-prod could you provide a review? Thanks!

Copy link
Contributor

@rowlandgeoff rowlandgeoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emilioalvap emilioalvap merged commit 41b1c4d into elastic:main Sep 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify ci Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-pack/heartbeat: "build constraints exclude all Go files" for Win tests
5 participants