Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #40692) [Processor\Script] Add option to prevent creation of new sessions #40793

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[8.15](backport #40692) [Processor\Script] Add option to prevent creation of new sessions #40793

merged 2 commits into from
Sep 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 12, 2024

Fixes #40690

Proposed commit message

Include an option called only_cached_sessions that causes the script processor to only use the pre-defined cached javascript sessions from the session pool. This option is off by default. Includes some unrelated fixes for lint errors related to unchecked errors returned by called functions.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No

Use cases

Prevent the Beat from temporarily allocating and deleting hundreds of javascript sessions during normal operation.

Allows using more expensive Javascript scripts knowing they will only undergo initialization a single time.

Allows funneling all Beat events through a single session

This is an automatic backport of pull request #40692 done by [Mergify](https://mergify.com).

@strawgate @mergify
[Processor\Script] Add option to prevent creation of new sessions (#4…
2882e5c 
…0692)

* Add option to prevent new session creation and pre-create cached sessions

(cherry picked from commit 3f3b988)
@mergify mergify bot requested a review from a team as a code owner September 12, 2024 16:34
@mergify mergify bot added the backport label Sep 12, 2024
@mergify mergify bot requested review from AndersonQ and rdner and removed request for a team September 12, 2024 16:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 12, 2024
@botelastic
Copy link

botelastic bot commented Sep 12, 2024

This pull request doesn't have a Team:<team> label.

@strawgate strawgate enabled auto-merge (squash) September 12, 2024 16:37
@strawgate strawgate merged commit 305f1e1 into 8.15 Sep 13, 2024
123 checks passed
@strawgate strawgate deleted the mergify/bp/8.15/pr-40692 branch September 13, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@strawgate strawgate

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlind23 @strawgate