Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat][azure-blob-storage] - Simplified state checkpoint calculation #40936

Merged
merged 13 commits into from
Oct 2, 2024

Conversation

ShourieG
Copy link
Contributor

Type of change

  • Enhancement

Proposed commit message

  • WHAT: Simplified state checkpoint calculation
  • WHY: The existing state checkpoint calculation logic was convoluted and depended on unreliable flag logic, then it has been simplified so that if errors occur they are become simpler to debug.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested a review from a team as a code owner September 21, 2024 06:04
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
Copy link
Contributor

mergify bot commented Sep 21, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 21, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 21, 2024
@ShourieG ShourieG added the Team:Security-Service Integrations Security Service Integrations Team label Sep 21, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@ShourieG ShourieG added enhancement needs_team Indicates that the issue/PR needs a Team:* label labels Sep 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label input:azure-blob-storage labels Sep 21, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 21, 2024
@ShourieG ShourieG added the Filebeat Filebeat label Sep 21, 2024
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit then lgtm

x-pack/filebeat/input/azureblobstorage/scheduler.go Outdated Show resolved Hide resolved
@ShourieG
Copy link
Contributor Author

addressed all PR comments

@ShourieG
Copy link
Contributor Author

ShourieG commented Oct 1, 2024

@efd6, can you approve this if all looks good.

@ShourieG ShourieG merged commit e345f28 into elastic:main Oct 2, 2024
22 checks passed
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
@ShourieG ShourieG deleted the abs/simplify_state branch October 3, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Filebeat Filebeat input:azure-blob-storage Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify azure-blob storage state logic computation
3 participants