-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace multierror with stdlib errors wrapping #41043
Open
kruskall
wants to merge
24
commits into
elastic:main
Choose a base branch
from
kruskall:feat/drop-multierror
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+303
−335
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
fef0a58
feat: replace multierror with stdlib errors wrapping
kruskall 3f9dd7f
lint: fix linting issues
kruskall 6e3cc29
lint: regenerate notice file
kruskall 8d389db
lint: fix linting issues
kruskall 6053d69
lint: fix linting issues
kruskall 4b9416c
lint: fix linting issues
kruskall 6214d97
lint: fix linting issues
kruskall 1511c5e
lint: fix linting issues
kruskall 54c663f
lint: fix linting issues
kruskall c5a3b9a
lint: fix linting issues
kruskall 712d258
lint: fix linting issues
kruskall eacde97
lint: fix linting issues
kruskall 88f930b
Merge branch 'main' into feat/drop-multierror
kruskall b3f3c10
Update auditbeat/module/auditd/config.go
kruskall 6c92592
Update auditbeat/module/file_integrity/config_test.go
kruskall ac27fd4
lint: merge lines
kruskall 777fada
lint: fix linter issues
kruskall 0437395
lint: fix linter issues
kruskall 794432e
lint: fix linter issues
kruskall d6debe0
Merge branch 'main' into feat/drop-multierror
kruskall c84a4bc
lint: rename errs variable
kruskall f429777
fix: update wrapping format
kruskall c686027
lint: go mod tidy
kruskall a5717bb
Merge branch 'main' into feat/drop-multierror
kruskall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:old-man-shouting-at-clouds: x/sys/unix has two instances of %w (both in code generators rather than lib code) and AFAICS no other form of error wrapping (it would be very strange if a package that sits at this level of the stack did). While not bound by go1compat or semver, it would be extremely surprising if this ever changed since code is copied from x/sys/unix into the std tree. But if it keeps people happy…